Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql, internal: fix typos in comments #27184

Merged
merged 4 commits into from
May 2, 2023
Merged

graphql, internal: fix typos in comments #27184

merged 4 commits into from
May 2, 2023

Conversation

DavidRomanovizc
Copy link
Contributor

What was wrong?

There are typos in the code comments and in other files

How was it fixed?

Fixed them

Cute Animal Picture

image

@karalabe
Copy link
Member

karalabe commented Apr 28, 2023

Quite a number of these were blind replaces without realising the originals were correct.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the marked changes

les/txrelay.go Outdated Show resolved Hide resolved
les/client.go Outdated Show resolved Hide resolved
internal/shutdowncheck/shutdown_tracker.go Outdated Show resolved Hide resolved
internal/jsre/pretty.go Outdated Show resolved Hide resolved
internal/jsre/jsre.go Outdated Show resolved Hide resolved
internal/debug/trace.go Outdated Show resolved Hide resolved
internal/build/gotool.go Outdated Show resolved Hide resolved
@deep709
Copy link

deep709 commented Apr 28, 2023

Always best innovative ideas .

internal/web3ext/web3ext.go Outdated Show resolved Hide resolved
@holiman holiman changed the title ✏️ Fix typos graphql, internal: fix typos in comments May 2, 2023
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@holiman holiman added this to the 1.11.7 milestone May 2, 2023
@holiman holiman merged commit 29c33d9 into ethereum:master May 2, 2023
shekhirin pushed a commit to shekhirin/go-ethereum that referenced this pull request Jun 6, 2023
* ✏️ Fix typos

* ⏪️ Revert changes

* Update internal/web3ext/web3ext.go

---------

Co-authored-by: Martin Holst Swende <martin@swende.se>
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
* ✏️ Fix typos

* ⏪️ Revert changes

* Update internal/web3ext/web3ext.go

---------

Co-authored-by: Martin Holst Swende <martin@swende.se>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants